Skip to content

Fix namespace closing for o2 in BunchFilling.h#14791

Merged
njacazio merged 1 commit intodevfrom
njacazio-patch-1
Nov 4, 2025
Merged

Fix namespace closing for o2 in BunchFilling.h#14791
njacazio merged 1 commit intodevfrom
njacazio-patch-1

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Nov 4, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@njacazio
Copy link
Collaborator Author

njacazio commented Nov 4, 2025

This should handle the ambigous namespace call:

FAILED: PWGCF/GenericFramework/Tasks/CMakeFiles/O2Physicsexe-analysis-cf-flow-generic-framework.dir/flowGenericFramework.cxx.o 
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/bin/c++ -DBOOST_ASIO_HAS_HAS_STD_CHRONO -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTAINER_DYN_LINK -DBOOST_CONTAINER_NO_LIB -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_IOSTREAMS_DYN_LINK -DBOOST_IOSTREAMS_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DDPL_ENABLE_BACKTRACE -DFAIRMQ_HAS_STD_FILESYSTEM=1 -DFAIRMQ_HAS_STD_PMR=1 -DFMT_SHARED -DRANS_ENABLE_JSON -DRANS_OPENMP -DROOT_SUPPORT_CLAD -I/sw/SOURCES/O2Physics/13633-slc9_x86-64/0/Common/Core -I/sw/SOURCES/O2Physics/13633-slc9_x86-64/0 -I/sw/SOURCES/O2Physics/13633-slc9_x86-64/0/PWGCF/GenericFramework/Core -isystem /sw/slc9_x86-64/O2/daily-20251104-0000-local1/include -isystem /sw/slc9_x86-64/Configuration/v2.8.0-45/include -isystem /sw/slc9_x86-64/boost/v1.83.0-alice2-44/include -isystem /sw/slc9_x86-64/Monitoring/v3.19.8-6/include -isystem /sw/slc9_x86-64/curl/7.70.0-20/include -isystem /sw/slc9_x86-64/FairMQ/v1.10.0-3/include/fairmq -isystem /sw/slc9_x86-64/FairMQ/v1.10.0-3/include -isystem /sw/slc9_x86-64/FairLogger/v2.1.0-10/include -isystem /sw/slc9_x86-64/fmt/11.1.2-7/include -isystem /sw/slc9_x86-64/ROOT/v6-36-04-alice2-2/include -isystem /sw/slc9_x86-64/O2/daily-20251104-0000-local1/include/GPU -isystem /sw/slc9_x86-64/RapidJSON/v1.1.0-alice2-23/include -isystem /sw/slc9_x86-64/arrow/v20.0.0-alice1-5/include -isystem /sw/slc9_x86-64/ms_gsl/4.0.0-19/include -isystem /sw/slc9_x86-64/Clang/v20.1.7-1/include -isystem /sw/slc9_x86-64/libuv/v1.40.0-21/include -isystem /sw/slc9_x86-64/FairRoot/v18.4.9-alice3-113/include -isystem /sw/slc9_x86-64/VMC/v2-0-101/include/vmc -isystem /sw/slc9_x86-64/Vc/1.4.5-5/include -isystem /sw/slc9_x86-64/TBB/v2021.5.0-24/include -isystem /sw/slc9_x86-64/libjalienO2/0.1.5-1/include -isystem /sw/slc9_x86-64/abseil/20240722.0-2/include -isystem /sw/slc9_x86-64/Common-O2/v1.6.3-25/include -fPIC -O2 -std=c++20 -Wall -Wextra -Werror   -O2 -g -DNDEBUG -pipe -fopenmp -MD -MT PWGCF/GenericFramework/Tasks/CMakeFiles/O2Physicsexe-analysis-cf-flow-generic-framework.dir/flowGenericFramework.cxx.o -MF PWGCF/GenericFramework/Tasks/CMakeFiles/O2Physicsexe-analysis-cf-flow-generic-framework.dir/flowGenericFramework.cxx.o.d -o PWGCF/GenericFramework/Tasks/CMakeFiles/O2Physicsexe-analysis-cf-flow-generic-framework.dir/flowGenericFramework.cxx.o -c /sw/SOURCES/O2Physics/13633-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGenericFramework.cxx
/sw/SOURCES/O2Physics/13633-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGenericFramework.cxx: In member function 'void FlowGenericFramework::processTrack(const TTrack&, const float&, const int&, DensityCorr)':
/sw/SOURCES/O2Physics/13633-slc9_x86-64/0/PWGCF/GenericFramework/Tasks/flowGenericFramework.cxx:814:19: error: reference to 'framework' is ambiguous
  814 |     if constexpr (framework::has_type_v<aod::mctracklabel::McParticleId, typename TTrack::all_columns>) {
      |                   ^~~~~~~~~
In file included from /sw/slc9_x86-64/O2/daily-20251104-0000-local1/include/Framework/DataTakingContext.h:14,
--
/sw/slc9_x86-64/O2/daily-20251104-0000-local1/include/CommonDataFormat/BunchFilling.h:112:11: note:                 'namespace framework { }'
  112 | namespace framework
      |           ^~~~~~~~~

@njacazio njacazio marked this pull request as ready for review November 4, 2025 09:28
@njacazio njacazio requested a review from shahor02 as a code owner November 4, 2025 09:28
@njacazio
Copy link
Collaborator Author

njacazio commented Nov 4, 2025

Hi @shahor02 I somehow hit this in AliceO2Group/O2Physics#13633 I'm compiling now with the local fix. Would the change be ok?

shahor02
shahor02 approved these changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Makes sense, apparently we have never messaged the BunchFilling before.

@njacazio njacazio enabled auto-merge (squash) November 4, 2025 10:38
@njacazio njacazio merged commit 898c793 into dev Nov 4, 2025
13 of 14 checks passed
@njacazio njacazio deleted the njacazio-patch-1 branch November 4, 2025 14:55
atriolo pushed a commit to atriolo/AliceO2 that referenced this pull request Nov 18, 2025
@njacazio @atriolo
Fix namespace closing for o2 in BunchFilling.h (AliceO2Group#14791)
4991499
atriolo pushed a commit to atriolo/AliceO2 that referenced this pull request Nov 18, 2025
@njacazio @atriolo
Fix namespace closing for o2 in BunchFilling.h (AliceO2Group#14791)
24da29b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@njacazio @shahor02